Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-29 Thread David Croswell
Can you remove 'phil...@ok-labs.com' from this mailing list / thread, as he no longer reads this email (and it's forward to me). Thanks, David --- David Croswell | IT Manager General Dynamics Cyber Solutions | Open Kernel Labs t +61 2 8003 9942 | m +61 466 719 764 e d

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-29 Thread Jean-Christophe DUBOIS
On 04/29/2013 06:49 PM, Peter Maydell wrote: On 29 April 2013 17:39, Jean-Christophe DUBOIS wrote: Peter (Maydel), will you pick it up as is (actually the v3 version) or do I need to send a new version of the patch (a v4) ? The last on-list version still has the wrong vmstate version fields,

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-29 Thread Peter Maydell
On 29 April 2013 17:39, Jean-Christophe DUBOIS wrote: > Peter (Maydel), will you pick it up as is (actually the v3 version) or do I > need to send a new version of the patch (a v4) ? The last on-list version still has the wrong vmstate version fields, I think? thanks -- PMM

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-29 Thread Jean-Christophe DUBOIS
On 04/28/2013 11:29 PM, Peter Chubb wrote: "Jean-Christophe" == Jean-Christophe DUBOIS writes: Jean-Christophe> This patch is providing a complete version of the Jean-Christophe> EPIT timer. Note, however that the GPT timer in the Jean-Christophe> same file is still not complete. Looks good.

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-28 Thread Peter Chubb
> "Jean-Christophe" == Jean-Christophe DUBOIS writes: Jean-Christophe> This patch is providing a complete version of the Jean-Christophe> EPIT timer. Note, however that the GPT timer in the Jean-Christophe> same file is still not complete. Looks good. You can add my Reviewed-by: Peter Chu

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-10 Thread Peter Maydell
On 10 April 2013 21:19, Jean-Christophe DUBOIS wrote: > To be honest with you Peter, I don't even know how these state information > are used. > > I never practiced VM migration with Qemu for now. > > Actually if you had a few pointers to a decent explanation, I would be > interested. There's doc

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-10 Thread Jean-Christophe DUBOIS
On 04/10/2013 10:07 PM, Peter Maydell wrote: On 10 April 2013 21:02, Jean-Christophe DUBOIS wrote: static const VMStateDescription vmstate_imx_timerp = { .name = "imx-timerp", -.version_id = 1, +.version_id = 2, .minimum_version_id = 1, .minimum_version_id_old = 1,

Re: [Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-10 Thread Peter Maydell
On 10 April 2013 21:02, Jean-Christophe DUBOIS wrote: > static const VMStateDescription vmstate_imx_timerp = { > .name = "imx-timerp", > -.version_id = 1, > +.version_id = 2, > .minimum_version_id = 1, > .minimum_version_id_old = 1, I said "all the version id fields" but y

[Qemu-devel] [PATCH v2] i.MX: implement a more correct version of EPIT timer.

2013-04-10 Thread Jean-Christophe DUBOIS
This patch is providing a complete version of the EPIT timer. Note, however that the GPT timer in the same file is still not complete. Signed-off-by: Jean-Christophe DUBOIS Change from v1: - bump up the version number on VMSTATE struct - fix comment --- hw/timer/imx_timer.c | 253