Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-23 Thread Auger Eric
Hi Eric, On 1/23/19 4:01 PM, Eric Blake wrote: > On 1/23/19 8:44 AM, Auger Eric wrote: > >>> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name': >>> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified >>> bound 256 equals destination size [-Werror=stringop-trunca

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-23 Thread Eric Blake
On 1/23/19 8:44 AM, Auger Eric wrote: >> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name': >> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound >> 256 equals destination size [-Werror=stringop-truncation] >> strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-23 Thread Auger Eric
Hi, On 1/23/19 3:23 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190117210245.18364-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker i

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190117210245.18364-1-eric.au...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Auger Eric
Hi Alexey, On 1/18/19 5:51 AM, Alexey Kardashevskiy wrote: > > > On 18/01/2019 08:02, Eric Auger wrote: >> In vfio_connect_container() the code that selects the >> iommu type can benefit from helpers such as >> vfio_iommu_get_type() and vfio_init_container(). As >> a result we end up with a swit

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-18 Thread Greg Kurz
On Thu, 17 Jan 2019 22:02:45 +0100 Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little

Re: [Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-17 Thread Alexey Kardashevskiy
On 18/01/2019 08:02, Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little bit more rea

[Qemu-devel] [PATCH v2] hw/vfio/common: Refactor container initialization

2019-01-17 Thread Eric Auger
In vfio_connect_container() the code that selects the iommu type can benefit from helpers such as vfio_iommu_get_type() and vfio_init_container(). As a result we end up with a switch/case on the iommu type that makes the code a little bit more readable and ready for addition of new iommu types. Als