Re: [Qemu-devel] [PATCH v2] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Marcel Apfelbaum
On 03/30/2017 06:44 PM, Suramya Shah wrote: Hi, Signed-off-by: Suramya Shah Please add the SOB after the description. Reviewed-by: Marcel Apfelbaum Please do not add a reviewer to your patch unless he approved /added his signature by himself. Running QEMU with qemu-system-unicore32 w

[Qemu-devel] [PATCH v2] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Suramya Shah
Signed-off-by: Suramya Shah Reviewed-by: Marcel Apfelbaum Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead --- hw/unicore32/puv3.c | 7 +-- 1 fi