Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-25 Thread Peter Maydell
On 25 September 2017 at 23:53, Alistair Francis wrote: > On Mon, Sep 25, 2017 at 3:38 PM, Peter Maydell > wrote: >> On 25 September 2017 at 22:16, Alistair Francis wrote: >>> On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell >>> wrote: Alistair, were you planning to provide a reviewed-by: f

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-25 Thread Alistair Francis
On Mon, Sep 25, 2017 at 3:38 PM, Peter Maydell wrote: > On 25 September 2017 at 22:16, Alistair Francis wrote: >> On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell >> wrote: >>> Alistair, were you planning to provide a reviewed-by: for this >>> patch (or did you have more review comments on it)? >

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-25 Thread Peter Maydell
On 25 September 2017 at 22:16, Alistair Francis wrote: > On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell > wrote: >> Alistair, were you planning to provide a reviewed-by: for this >> patch (or did you have more review comments on it)? > > Ah woops, this slipped through. Looks fine to me then. > >

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-25 Thread Alistair Francis
On Mon, Sep 25, 2017 at 12:27 PM, Peter Maydell wrote: > On 20 September 2017 at 07:19, Michael Olbrich > wrote: >> On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: >>> On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich >>> wrote: >>> > On Mon, Sep 18, 2017 at 02:28:26PM -0700, A

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-25 Thread Peter Maydell
On 20 September 2017 at 07:19, Michael Olbrich wrote: > On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: >> On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich >> wrote: >> > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: >> >> On Sat, Sep 16, 2017 at 3:35 AM, Mic

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: > On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich > wrote: > > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > >> wrote: > >> > hw/sd/sd.c | 12 ++-

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Alistair Francis
On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich wrote: > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich >> wrote: >> > The current code checks if the next block exceeds the size of the card. >> > This generates an error while

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > wrote: > > The current code checks if the next block exceeds the size of the card. > > This generates an error while reading the last block of the card. > > Do the out-of-bounds c

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-18 Thread Alistair Francis
On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich wrote: > The current code checks if the next block exceeds the size of the card. > This generates an error while reading the last block of the card. > Do the out-of-bounds check when starting to read a new block to fix this. > > This issue became vi

[Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread Michael Olbrich
The current code checks if the next block exceeds the size of the card. This generates an error while reading the last block of the card. Do the out-of-bounds check when starting to read a new block to fix this. This issue became visible with increased error checking in Linux 4.13. Signed-off-by: