Re: [Qemu-devel] [PATCH v2] hw/char/escc: Lower irq when transmit buffer is filled

2019-04-19 Thread Stephen Checkoway
> On Apr 18, 2019, at 08:13, Philippe Mathieu-Daudé wrote: > > On 4/17/19 2:50 AM, Stephen Checkoway wrote: >> The SCC/ESCC will briefly stop asserting an interrupt when the >> transmit FIFO is filled. >> >> This code doesn't model the transmit FIFO/shift register so the >> pending transmit i

Re: [Qemu-devel] [PATCH v2] hw/char/escc: Lower irq when transmit buffer is filled

2019-04-18 Thread Philippe Mathieu-Daudé
On 4/17/19 2:50 AM, Stephen Checkoway wrote: > The SCC/ESCC will briefly stop asserting an interrupt when the > transmit FIFO is filled. > > This code doesn't model the transmit FIFO/shift register so the > pending transmit interrupt is never deasserted which means that an > edge-triggered interru

[Qemu-devel] [PATCH v2] hw/char/escc: Lower irq when transmit buffer is filled

2019-04-16 Thread Stephen Checkoway
The SCC/ESCC will briefly stop asserting an interrupt when the transmit FIFO is filled. This code doesn't model the transmit FIFO/shift register so the pending transmit interrupt is never deasserted which means that an edge-triggered interrupt controller will never see the low-to-high transition i