Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
On 2015-3-12 22:03, Stefan Hajnoczi wrote: > On Thu, Mar 12, 2015 at 04:35:24PM +0800, Ting Wang wrote: >> +void hmp_info_iothreads(Monitor *mon, const QDict *qdict) >> +{ >> +IOThreadInfoList *head = NULL, *elem = NULL; >> + >> +head = qmp_query_iothreads(NULL); >> +if (!head) { >> +

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Stefan Hajnoczi
On Thu, Mar 12, 2015 at 04:35:24PM +0800, Ting Wang wrote: > +void hmp_info_iothreads(Monitor *mon, const QDict *qdict) > +{ > +IOThreadInfoList *head = NULL, *elem = NULL; > + > +head = qmp_query_iothreads(NULL); > +if (!head) { > +monitor_printf(mon, "No iothread has been adde

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Fam Zheng
On Thu, 03/12 17:32, Ting Wang wrote: > It is a command in "info" group, I think documentation as follows is OK, do > you agree with it? > >> diff --git a/hmp-commands.hx b/hmp-commands.hx > >> index d5022d8..67d76ed 100644 > >> --- a/hmp-commands.hx > >> +++ b/hmp-commands.hx > >> @@ -1746,6 +174

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
On 2015-3-12 17:05, Fam Zheng wrote: > On Thu, 03/12 16:35, Ting Wang wrote: >> Make "info iothreads" available on the HMP monitor. >> >> The results are as follows: >> id1: thread_id1 >> id2: thread_id2 > > Does this match the actual output format? I think you're missing a "=". > >> >> Signed-

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
On 2015-3-12 17:05, Fam Zheng wrote: > On Thu, 03/12 16:35, Ting Wang wrote: >> Make "info iothreads" available on the HMP monitor. >> >> The results are as follows: >> id1: thread_id1 >> id2: thread_id2 > > Does this match the actual output format? I think you're missing a "=". > Oh, sorry. I

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Fam Zheng
On Thu, 03/12 16:35, Ting Wang wrote: > Make "info iothreads" available on the HMP monitor. > > The results are as follows: > id1: thread_id1 > id2: thread_id2 Does this match the actual output format? I think you're missing a "=". > > Signed-off-by: Ting Wang > --- > v2: add braces for if > -

[Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
Make "info iothreads" available on the HMP monitor. The results are as follows: id1: thread_id1 id2: thread_id2 Signed-off-by: Ting Wang --- v2: add braces for if --- hmp-commands.hx | 2 ++ hmp.c | 22 ++ hmp.h | 1 + monitor.c | 7 +++ 4 fi