Re: [Qemu-devel] [PATCH v2] error: passing a negative value to an os_errno is wrong

2014-11-09 Thread SeokYeon Hwang
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, November 07, 2014 4:41 PM > To: Amos Kong > Cc: SeokYeon Hwang; mre...@redhat.com; paolo.bonz...@gmail.com; qemu- > de...@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2] erro

Re: [Qemu-devel] [PATCH v2] error: passing a negative value to an os_errno is wrong

2014-11-06 Thread Markus Armbruster
Amos Kong writes: > On Fri, Nov 07, 2014 at 11:24:55AM +0900, SeokYeon Hwang wrote: >> Added 'assert(os_errno > 0)' in 'error_set_errno()'. >> Fixed errno since it passes wrong value to 'error_set_errno()'. >> >> Signed-off-by: SeokYeon Hwang >> --- >> hw/pci/pcie.c | 2 +- >> util/error.c |

Re: [Qemu-devel] [PATCH v2] error: passing a negative value to an os_errno is wrong

2014-11-06 Thread Amos Kong
On Fri, Nov 07, 2014 at 11:24:55AM +0900, SeokYeon Hwang wrote: > Added 'assert(os_errno > 0)' in 'error_set_errno()'. > Fixed errno since it passes wrong value to 'error_set_errno()'. > > Signed-off-by: SeokYeon Hwang > --- > hw/pci/pcie.c | 2 +- > util/error.c | 1 + > 2 files changed, 2 ins

[Qemu-devel] [PATCH v2] error: passing a negative value to an os_errno is wrong

2014-11-06 Thread SeokYeon Hwang
Added 'assert(os_errno > 0)' in 'error_set_errno()'. Fixed errno since it passes wrong value to 'error_set_errno()'. Signed-off-by: SeokYeon Hwang --- hw/pci/pcie.c | 2 +- util/error.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 5845