Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 07:49 PM, Stefan Weil wrote: + if [ -e "$source_path/$f" -a ! -e "$f" ]; then + symlink "$source_path/$f" "$f" + fi Please use && instead of -a, and "! [" instead of "[ !". Paolo

Re: [Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Stefan Weil
Am 25.05.2011 19:30, schrieb Peter Maydell: When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-t

[Qemu-devel] [PATCH v2] configure: Don't create symlinks to nonexistent targets

2011-05-25 Thread Peter Maydell
When we create the symlinks to source tree files, don't create them if the file is not actually present in the source tree; this will happen if the file is in a git submodule that wasn't checked out. This also avoids the odd effect where an in-source-tree configure will end up creating the missing