Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-11 Thread Gonglei (Arei)
Hi, > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > > index d1afc76..399a2ef 100644 > > --- a/hw/display/cirrus_vga.c > > +++ b/hw/display/cirrus_vga.c > > @@ -2959,6 +2959,14 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) > > PCIDeviceClass *pc = PCI_DEVICE_GET_CLA

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-11 Thread Gonglei (Arei)
Hi, > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > > index d1afc76..399a2ef 100644 > > --- a/hw/display/cirrus_vga.c > > +++ b/hw/display/cirrus_vga.c > > @@ -2959,6 +2959,14 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) > > PCIDeviceClass *pc = PCI_DEVICE_GET_CLA

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 13:04, schrieb arei.gong...@huawei.com: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 MB vra

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Michael Tokarev
09.05.2014 15:04, arei.gong...@huawei.com wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 MB vram siz

[Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei --- v2: fix checkpatch fails. "