Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Stefan Weil
Am 18.11.2012 22:09, schrieb Blue Swirl: Thanks, applied. On Fri, Nov 16, 2012 at 5:35 PM, Paolo Bonzini wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This patch uses a surpri

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Blue Swirl
Thanks, applied. On Fri, Nov 16, 2012 at 5:35 PM, Paolo Bonzini wrote: > Weak symbols were a nice idea, but they turned out not to be a good one. > Toolchain support is just too sparse, in particular llvm-gcc is totally > broken. > > This patch uses a surprisingly low-tech approach: a static libr

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Stefan Weil
Am 18.11.2012 17:10, schrieb Paolo Bonzini: Il 16/11/2012 19:18, Peter Maydell ha scritto: On 16 November 2012 17:35, Paolo Bonzini wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Paolo Bonzini
Il 16/11/2012 19:18, Peter Maydell ha scritto: > On 16 November 2012 17:35, Paolo Bonzini wrote: >> Weak symbols were a nice idea, but they turned out not to be a good one. >> Toolchain support is just too sparse, in particular llvm-gcc is totally >> broken. >> >> This patch uses a surprisingly lo

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 17:35, Paolo Bonzini wrote: > Weak symbols were a nice idea, but they turned out not to be a good one. > Toolchain support is just too sparse, in particular llvm-gcc is totally > broken. > > This patch uses a surprisingly low-tech approach: a static library. > Symbols in a stat

[Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-16 Thread Paolo Bonzini
Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This patch uses a surprisingly low-tech approach: a static library. Symbols in a static library are always overridden by symbols in an object fil