Re: [Qemu-devel] [PATCH v2] block: always compile-check debug prints

2016-04-28 Thread Eric Blake
On 04/28/2016 07:44 PM, Zhou Jie wrote: > Files with conditional debug statements should ensure that the printf is > always compiled. > This prevents bitrot of the format string of the debug statement. The commit message needs to mention... > > Signed-off-by: Zhou Jie > --- Right here would be

[Qemu-devel] [PATCH v2] block: always compile-check debug prints

2016-04-28 Thread Zhou Jie
Files with conditional debug statements should ensure that the printf is always compiled. This prevents bitrot of the format string of the debug statement. Signed-off-by: Zhou Jie --- block/curl.c | 10 -- block/sheepdog.c | 13 - 2 files changed, 16 insertions(+), 7 dele