Re: [Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

2017-06-16 Thread Max Reitz
On 2017-06-13 22:57, Max Reitz wrote: > uri_parse(...)->scheme may be NULL. In fact, probably every field may be > NULL, and the callers do test this for all of the other fields but not > for scheme (except for block/gluster.c; block/vxhs.c does not access > that field at all). > > We can easily f

Re: [Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170613205726.13544-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri

[Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

2017-06-13 Thread Max Reitz
uri_parse(...)->scheme may be NULL. In fact, probably every field may be NULL, and the callers do test this for all of the other fields but not for scheme (except for block/gluster.c; block/vxhs.c does not access that field at all). We can easily fix this by using g_strcmp0() instead of strcmp().