Re: [Qemu-devel] [PATCH v2] audio: intel-hda: do not use old_mmio accesses

2017-08-24 Thread Gerd Hoffmann
On Wed, 2017-08-23 at 20:37 +0100, Matt Parker wrote: > +    intel_hda_reg_write(d, reg, val, (1UL << (size * 8)) - 1); Hmm? Same as v1, forgot to commit the changes? cheers, Gerd

Re: [Qemu-devel] [PATCH v2] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
I've just noticed the suggested changes from the v1 patch regarding using MAKE_64BIT_MASK. This patch is can be ignored for now. On 23 August 2017 at 20:37, Matt Parker wrote: > intel-hda is currently using the old_mmio accessors for io. > This updates the device to use .read and .write accessors

[Qemu-devel] [PATCH v2] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
intel-hda is currently using the old_mmio accessors for io. This updates the device to use .read and .write accessors instead. Signed-off-by: Matt Parker --- hw/audio/intel-hda.c | 57 +--- 1 file changed, 10 insertions(+), 47 deletions(-) diff --