Re: [Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Eric Blake
On 04/27/2012 04:20 PM, Andreas Färber wrote: > Am 27.04.2012 23:55, schrieb Eric Blake: >> On 04/27/2012 02:16 PM, Peter Portante wrote: >>> The package config check for gthreads might have already placed a >>> -lrt switch in LIBS earlier. >>> >>> Refactored the code from the pthread switch remova

Re: [Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Eric Blake
On 04/27/2012 04:16 PM, Peter Maydell wrote: > On 27 April 2012 22:55, Eric Blake wrote: >> Shorter (and probably faster) to write this as: >> >> add_to_libs() { >> case " $LIBS " in >>" $1 ") ;; >>*) LIBS="$1 $LIBS" ;; >> esac >> } > > ...doesn't that need to be > *" $1 "*) ;; Ye

Re: [Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 27.04.2012 23:55, schrieb Eric Blake: > On 04/27/2012 02:16 PM, Peter Portante wrote: >> The package config check for gthreads might have already placed a >> -lrt switch in LIBS earlier. >> >> Refactored the code from the pthread switch removal, fr

Re: [Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Peter Maydell
On 27 April 2012 22:55, Eric Blake wrote: > Shorter (and probably faster) to write this as: > > add_to_libs() { >  case " $LIBS " in >    " $1 ") ;; >    *) LIBS="$1 $LIBS" ;; >  esac > } ...doesn't that need to be *" $1 "*) ;; ? -- PMM

Re: [Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Eric Blake
On 04/27/2012 02:16 PM, Peter Portante wrote: > The package config check for gthreads might have already placed > a -lrt switch in LIBS earlier. > > Refactored the code from the pthread switch removal, from commit > e3c56761b465a4253871c32b06ebbc2d8b3fc3e1, to make it work for the > more general c

[Qemu-devel] [PATCH v2] Remove the extra -lrt switch

2012-04-27 Thread Peter Portante
The package config check for gthreads might have already placed a -lrt switch in LIBS earlier. Refactored the code from the pthread switch removal, from commit e3c56761b465a4253871c32b06ebbc2d8b3fc3e1, to make it work for the more general case. Signed-off-by: Peter Portante --- configure | 26