Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support

2013-03-27 Thread Stefan Berger
On 03/27/2013 11:26 AM, Paolo Bonzini wrote: Il 27/03/2013 13:21, Stefan Berger ha scritto: With the above file naming and directory placement I followed the pattern of backends/rng.c include/qemu/rng.h So are you planning on having them renamed and moved as well? Uff, we're really bad at con

Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support

2013-03-27 Thread Paolo Bonzini
Il 27/03/2013 13:21, Stefan Berger ha scritto: > > With the above file naming and directory placement I followed the > pattern of > > backends/rng.c > include/qemu/rng.h > > So are you planning on having them renamed and moved as well? Uff, we're really bad at consistent naming. :) Given the a

Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support

2013-03-27 Thread Stefan Berger
On 03/27/2013 08:06 AM, Paolo Bonzini wrote: Il 26/03/2013 17:28, Stefan Berger ha scritto: QOM-ified the TPM support with much code borrowed from the rng implementation. What's missing may be that the tpm/tpm_passthrough.c be moved into backends/ . Signed-off-by: Stefan Berger --- v1->v2:

Re: [Qemu-devel] [PATCH v2] QOM-ify the TPM support

2013-03-27 Thread Paolo Bonzini
Il 26/03/2013 17:28, Stefan Berger ha scritto: > QOM-ified the TPM support with much code borrowed from the rng implementation. > > What's missing may be that the tpm/tpm_passthrough.c be moved into backends/ . > > Signed-off-by: Stefan Berger > > --- > v1->v2: > - followed to git revision e

[Qemu-devel] [PATCH v2] QOM-ify the TPM support

2013-03-26 Thread Stefan Berger
QOM-ified the TPM support with much code borrowed from the rng implementation. What's missing may be that the tpm/tpm_passthrough.c be moved into backends/ . Signed-off-by: Stefan Berger --- v1->v2: - followed to git revision e769bdc26 --- backends/Makefile.objs |2 backends/tpm.c