- On Jul 7, 2017, at 4:31 PM, Daniel P. Berrange berra...@redhat.com wrote:
> On Fri, Jul 07, 2017 at 12:38:47AM +0530, Ishani Chugh wrote:
>> This patch intends to make qmp.py compatible with both python2 and python3.
>>
>> * Python 3 does not have dict.has_key(key), use key in dict instead
Ishani Chugh writes:
> This patch intends to make qmp.py compatible with both python2 and python3.
>
> * Python 3 does not have dict.has_key(key), use key in dict instead
> * Avoid line-based I/O since Python 2/3 have different character
>encoding behavior. Explicitly encode/decode JSON UT
On Fri, Jul 07, 2017 at 12:38:47AM +0530, Ishani Chugh wrote:
> This patch intends to make qmp.py compatible with both python2 and python3.
>
> * Python 3 does not have dict.has_key(key), use key in dict instead
> * Avoid line-based I/O since Python 2/3 have different character
>encoding beh
On Fri, Jul 07, 2017 at 12:38:47AM +0530, Ishani Chugh wrote:
Commit messages usually begin with a prefix indicating the affected
component. This makes it easier for code reviewers and maintainers to
browse email subjects and the git log. I recommend the following commit
message:
scripts/qmp:
This patch intends to make qmp.py compatible with both python2 and python3.
* Python 3 does not have dict.has_key(key), use key in dict instead
* Avoid line-based I/O since Python 2/3 have different character
encoding behavior. Explicitly encode/decode JSON UTF-8.
* Replace print by print f
