Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-16 Thread Blue Swirl
On Thu, Feb 14, 2013 at 10:09 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Thu, Feb 14, 2013 at 2:34 AM, Anthony Liguori >> wrote: >>> Joel Schopp writes: >>> >> +if(popen_file == NULL) { > > Please make a preparatory patch which adds missing spaces between 'if'

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-14 Thread Anthony Liguori
Blue Swirl writes: > On Thu, Feb 14, 2013 at 2:34 AM, Anthony Liguori > wrote: >> Joel Schopp writes: >> > +if(popen_file == NULL) { Please make a preparatory patch which adds missing spaces between 'if' statements and '('. >>> >>> I'll do a preparatory style cleanup pat

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-14 Thread Blue Swirl
On Thu, Feb 14, 2013 at 2:34 AM, Anthony Liguori wrote: > Joel Schopp writes: > +if(popen_file == NULL) { >>> >>> Please make a preparatory patch which adds missing spaces between 'if' >>> statements and '('. >> >> I'll do a preparatory style cleanup patch of existing code if it is >> de

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Anthony Liguori
Joel Schopp writes: >>> +if(popen_file == NULL) { >> >> Please make a preparatory patch which adds missing spaces between 'if' >> statements and '('. > > I'll do a preparatory style cleanup patch of existing code if it is > deemed necessary by the maintainers, but I don't think it's a good >

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Joel Schopp
+if(popen_file == NULL) { Please make a preparatory patch which adds missing spaces between 'if' statements and '('. I'll do a preparatory style cleanup patch of existing code if it is deemed necessary by the maintainers, but I don't think it's a good idea. The patch as it stands now

Re: [Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Blue Swirl
On Wed, Feb 13, 2013 at 8:43 PM, Joel Schopp wrote: > This patch reorganizes qemu file operations to be in their own source file > instead of being lumped in savevm.c. Besides being more logical for > maintenance > it also makes it easier for future users of the file functions to add tests. > >

[Qemu-devel] [PATCH v2] Move File operations to qemu-file.c

2013-02-13 Thread Joel Schopp
This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v2 forward port to resolve conflicts, strip trailing whitespace d