Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-07 Thread Avi Kivity
On 10/05/2012 06:45 PM, Peter Maydell wrote: > On 4 October 2012 11:36, Avi Kivity wrote: >> diff --git a/targphys.h b/targphys.h >> index bd4938f..08cade9 100644 >> --- a/targphys.h >> +++ b/targphys.h >> @@ -3,25 +3,10 @@ >> #ifndef TARGPHYS_H >> #define TARGPHYS_H >> >> -#ifdef TARGET_PHYS_AD

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-07 Thread Avi Kivity
On 10/04/2012 08:15 PM, Stefan Weil wrote: > Am 04.10.2012 12:36, schrieb Avi Kivity: >> The hassle and compile time overhead of maintaining both 32-bit and >> 64-bit >> capable source isn't worth the tiny performance advantage which is >> seen on >> a minority of configurations. Switch to compili

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-05 Thread Peter Maydell
On 4 October 2012 11:36, Avi Kivity wrote: > diff --git a/targphys.h b/targphys.h > index bd4938f..08cade9 100644 > --- a/targphys.h > +++ b/targphys.h > @@ -3,25 +3,10 @@ > #ifndef TARGPHYS_H > #define TARGPHYS_H > > -#ifdef TARGET_PHYS_ADDR_BITS > +#define TARGET_PHYS_ADDR_BITS 64 > /* target

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-05 Thread Anthony Liguori
Blue Swirl writes: > On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil wrote: >> Am 05.10.2012 04:10, schrieb Anthony Liguori: >> >>> Avi Kivity writes: >>> The hassle and compile time overhead of maintaining both 32-bit and 64-bit capable source isn't worth the tiny performance advant

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil wrote: > Am 05.10.2012 04:10, schrieb Anthony Liguori: > >> Avi Kivity writes: >> >>> The hassle and compile time overhead of maintaining both 32-bit and >>> 64-bit >>> capable source isn't worth the tiny performance advantage which is seen >>> on >>> a

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Stefan Weil
Am 05.10.2012 04:10, schrieb Anthony Liguori: Avi Kivity writes: The hassle and compile time overhead of maintaining both 32-bit and 64-bit capable source isn't worth the tiny performance advantage which is seen on a minority of configurations. Switch to compiling libhw only once, with target

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Anthony Liguori
Avi Kivity writes: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr_t unconditionally typedefed to

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Stefan Weil
Am 04.10.2012 12:36, schrieb Avi Kivity: The hassle and compile time overhead of maintaining both 32-bit and 64-bit capable source isn't worth the tiny performance advantage which is seen on a minority of configurations. Switch to compiling libhw only once, with target_phys_addr_t unconditionall

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Michael Walle
Am Donnerstag 04 Oktober 2012, 12:36:04 schrieb Avi Kivity: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_p

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 10:36 AM, Avi Kivity wrote: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Anthony Liguori
Avi Kivity writes: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr_t unconditionally typedefed to

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Max Filippov
On Thu, Oct 4, 2012 at 2:36 PM, Avi Kivity wrote: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr_

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Edgar E. Iglesias
On Thu, Oct 04, 2012 at 12:36:04PM +0200, Avi Kivity wrote: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_p

[Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Avi Kivity
The hassle and compile time overhead of maintaining both 32-bit and 64-bit capable source isn't worth the tiny performance advantage which is seen on a minority of configurations. Switch to compiling libhw only once, with target_phys_addr_t unconditionally typedefed to uint64_t. Signed-off-by: Av