Re: [Qemu-devel] [PATCH v2] HACKING: Document 'struct' keyword usage

2019-08-13 Thread Paolo Bonzini
On 13/08/19 08:44, Thomas Huth wrote: > Maybe s/Each struct/Each global struct/ ? Or "non-local" or something > similar? Sometimes, you also define a struct just within a function, and > in that case we don't require the typedef, do we? I changed it to "each named struct" and queued. Thanks, Pao

Re: [Qemu-devel] [PATCH v2] HACKING: Document 'struct' keyword usage

2019-08-12 Thread Thomas Huth
On 8/13/19 1:46 AM, Eduardo Habkost wrote: > Sometimes we use the 'struct' keyword in headers to help us > reduce dependencies between header files. Document that > practice. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Use paragraphs written b

[Qemu-devel] [PATCH v2] HACKING: Document 'struct' keyword usage

2019-08-12 Thread Eduardo Habkost
Sometimes we use the 'struct' keyword in headers to help us reduce dependencies between header files. Document that practice. Signed-off-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use paragraphs written by Paolo Bonzini at https://www.mail-archive.com/qemu-devel@