Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-07-15 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 6/26/19 6:49 PM, Stefano Garzarella wrote: > > On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: > >> In hmp_change(), the variable hmp_mon is only used > >> by code under #ifdef CONFIG_VNC. This results in a build > >>

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-06-26 Thread Philippe Mathieu-Daudé
On 6/26/19 6:49 PM, Stefano Garzarella wrote: > On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: >> In hmp_change(), the variable hmp_mon is only used >> by code under #ifdef CONFIG_VNC. This results in a build >> error when VNC is configured out with the default of >> treati

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-06-26 Thread Stefano Garzarella
On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: > > monitor/hmp-cmds.c: In f

Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-06-25 Thread Dr. David Alan Gilbert
* Christophe de Dinechin (dinec...@redhat.com) wrote: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: > > monitor/hmp-cmds.c: In function ‘hmp_chang

[Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

2019-06-25 Thread Christophe de Dinechin
In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function ‘hmp_change’: monitor/hmp-cmds.c:1946:17: error: unused variable ‘hmp_mon’