Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-26 Thread Michael Roth
On Wed, Sep 26, 2012 at 12:33:17PM +0200, Paolo Bonzini wrote: > Il 26/09/2012 12:20, Kevin Wolf ha scritto: > >>> >> QIDL_DECLARE(RTCState) { > >>> >> > >>> >> ISADevice dev qidl(immutable); > >>> >> M

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-26 Thread Paolo Bonzini
Il 26/09/2012 12:20, Kevin Wolf ha scritto: >>> >> QIDL_DECLARE(RTCState) { >>> >> >>> >> ISADevice dev qidl(immutable); >>> >> MemoryRegion io qidl(immutable); >> > >> > Just like sparse is a "compile

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-26 Thread Kevin Wolf
Am 25.09.2012 23:12, schrieb Anthony Liguori: > Michael Roth writes: > >> On Tue, Sep 25, 2012 at 08:37:16AM +0200, Paolo Bonzini wrote: >>> Il 24/09/2012 20:14, Michael Roth ha scritto: I went with qUppercase because it avoids all the previous issues with using leading undersco

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-26 Thread Paolo Bonzini
Il 25/09/2012 23:12, Anthony Liguori ha scritto: > Just like sparse is a "compiler", so is qidl. We are free to use the > '_' + lowercase prefix. > > ISADevice _immutable dev; > > It's an established practice in wide-use. But QEMU is also compiled with GCC, so we're not. The Linux ke

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-25 Thread Anthony Liguori
Michael Roth writes: > On Tue, Sep 25, 2012 at 08:37:16AM +0200, Paolo Bonzini wrote: >> Il 24/09/2012 20:14, Michael Roth ha scritto: >> >>> > > I went with qUppercase because it avoids all the previous issues with >> >>> > > using leading underscores, and it's reserved in terms of QEMU coding >

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-25 Thread Michael Roth
On Tue, Sep 25, 2012 at 08:37:16AM +0200, Paolo Bonzini wrote: > Il 24/09/2012 20:14, Michael Roth ha scritto: > >>> > > I went with qUppercase because it avoids all the previous issues with > >>> > > using leading underscores, and it's reserved in terms of QEMU coding > >>> > > guidelines as far a

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-24 Thread Paolo Bonzini
Il 24/09/2012 20:14, Michael Roth ha scritto: >>> > > I went with qUppercase because it avoids all the previous issues with >>> > > using leading underscores, and it's reserved in terms of QEMU coding >>> > > guidelines as far as I can tell (we generally require leading capital >>> > > for typedefs

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-24 Thread Michael Roth
On Sat, Sep 22, 2012 at 02:33:52PM +, Blue Swirl wrote: > On Fri, Sep 21, 2012 at 4:24 PM, Michael Roth > wrote: > > On Fri, Sep 21, 2012 at 05:57:42PM +0200, Paolo Bonzini wrote: > >> Il 21/09/2012 16:07, Michael Roth ha scritto: > >> > > >> > QIDL_DECLARE(SerialDevice) { > >> >

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 4:24 PM, Michael Roth wrote: > On Fri, Sep 21, 2012 at 05:57:42PM +0200, Paolo Bonzini wrote: >> Il 21/09/2012 16:07, Michael Roth ha scritto: >> > >> > QIDL_DECLARE(SerialDevice) { >> > SysBusDevice parent; >> > >> > uint8_t thr; /* transmi

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-21 Thread Michael Roth
On Fri, Sep 21, 2012 at 05:57:42PM +0200, Paolo Bonzini wrote: > Il 21/09/2012 16:07, Michael Roth ha scritto: > > > > QIDL_DECLARE(SerialDevice) { > > SysBusDevice parent; > > > > uint8_t thr; /* transmit holding register */ > > uint8_t lsr;

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-21 Thread Paolo Bonzini
Il 21/09/2012 16:07, Michael Roth ha scritto: > > QIDL_DECLARE(SerialDevice) { > SysBusDevice parent; > > uint8_t thr; /* transmit holding register */ > uint8_t lsr; /* line status register */ > uint8_t ier; /* interrupt e

[Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-21 Thread Michael Roth
These patches are based are origin/master, and can also be obtained from: git://github.com/mdroth/qemu.git qidl-base-v2 Changes since v1: - Simplified declaration format for QIDL-fied structures (Anthony, Blue) - Documentations fix-ups and clarifications (Eric, Peter) - Reduced build-time imp