Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 18:35, Stefan Berger wrote: > Laszlo Ersek wrote on 07/30/2014 12:18:02 PM: > >> From: Laszlo Ersek >> To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS >> Cc: qemu-devel@nongnu.org, Stefan Berger >> Date: 07/30/2014 12:18 PM >> Subject: Re: [PATCH v2] Add ACPI tables for TP

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
Laszlo Ersek wrote on 07/30/2014 12:18:02 PM: > From: Laszlo Ersek > To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS > Cc: qemu-devel@nongnu.org, Stefan Berger > Date: 07/30/2014 12:18 PM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On 07/30/14 18:10, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 18:11, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 06:07:28PM +0200, Laszlo Ersek wrote: >> On 07/30/14 17:52, Michael S. Tsirkin wrote: >>> How does EFI want to handle TCPA? Does caller allocate it >>> log and fill in the address? >> >> TPM 1.2 seems to be completely absent fr

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 18:07, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 06:02:21PM +0200, Laszlo Ersek wrote: >> On 07/30/14 17:37, Michael S. Tsirkin wrote: >> >>> 1. execute alloc instructions, building a data structure mapping fwcfg >>>file names to memory. >> >> Yes, edk2 currently lacks a g

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 12:05:56 PM: > From: "Michael S. Tsirkin" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan > Berger > Date: 07/30/2014 12:05 PM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On Wed, Jul 30, 2014 at 11:59:4

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 18:10, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 12:03:46PM -0400, Stefan Berger wrote: >> Laszlo Ersek wrote on 07/30/2014 11:58:52 AM: >>> In the short term, probably skip TCPA, or advise users in documentation >>> not to enable the TPM device when running OVMF. > > Hmm b

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 12:03:46PM -0400, Stefan Berger wrote: > Laszlo Ersek wrote on 07/30/2014 11:58:52 AM: > > > From: Laszlo Ersek > > To: Stefan Berger/Watson/IBM@IBMUS > > Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, > > Stefan Berger > > Date: 07/30/2014 11:59 AM > > Subject: Re: [

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 06:02:21PM +0200, Laszlo Ersek wrote: > On 07/30/14 17:37, Michael S. Tsirkin wrote: > > > 1. execute alloc instructions, building a data structure mapping fwcfg > >file names to memory. > > Yes, edk2 currently lacks a good (== sub-linear) dictionary data type. > This

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 18:05, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 11:59:43AM -0400, Stefan Berger wrote: >> "Michael S. Tsirkin" wrote on 07/30/2014 11:50:36 AM: >> >>> From: "Michael S. Tsirkin" >>> To: Stefan Berger/Watson/IBM@IBMUS >>> Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan >>>

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
Laszlo Ersek wrote on 07/30/2014 12:07:28 PM: > From: Laszlo Ersek > To: "Michael S. Tsirkin" > Cc: Stefan Berger/Watson/IBM@IBMUS, qemu-devel@nongnu.org, Stefan > Berger > Date: 07/30/2014 12:07 PM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On 07/30/14 17:52, Michael S. Tsirkin w

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 06:07:28PM +0200, Laszlo Ersek wrote: > On 07/30/14 17:52, Michael S. Tsirkin wrote: > > On Wed, Jul 30, 2014 at 05:37:26PM +0200, Laszlo Ersek wrote: > >> On 07/30/14 17:10, Stefan Berger wrote: > >>> Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: > >>> > From: Laszlo

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:52, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 05:37:26PM +0200, Laszlo Ersek wrote: >> On 07/30/14 17:10, Stefan Berger wrote: >>> Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: >>> From: Laszlo Ersek To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 11:59:43AM -0400, Stefan Berger wrote: > "Michael S. Tsirkin" wrote on 07/30/2014 11:50:36 AM: > > > From: "Michael S. Tsirkin" > > To: Stefan Berger/Watson/IBM@IBMUS > > Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan > > Berger > > Date: 07/30/2014 11:50 AM > > Subjec

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
Laszlo Ersek wrote on 07/30/2014 11:58:52 AM: > From: Laszlo Ersek > To: Stefan Berger/Watson/IBM@IBMUS > Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, > Stefan Berger > Date: 07/30/2014 11:59 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On 07/30/14 17:44, Stefan Berger wrote:

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:37, Michael S. Tsirkin wrote: > 1. execute alloc instructions, building a data structure mapping fwcfg >file names to memory. Yes, edk2 currently lacks a good (== sub-linear) dictionary data type. This week I started porting a red-black tree library that I had originally writte

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 11:50:36 AM: > From: "Michael S. Tsirkin" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan > Berger > Date: 07/30/2014 11:50 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On Wed, Jul 30, 2014 at 11:29:3

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:44, Stefan Berger wrote: > Laszlo Ersek wrote on 07/30/2014 11:41:10 AM: > >> From: Laszlo Ersek >> To: Stefan Berger/Watson/IBM@IBMUS, "Michael S. Tsirkin" >> Cc: qemu-devel@nongnu.org, Stefan Berger >> Date: 07/30/2014 11:41 AM >> Subject: Re: [PATCH v2] Add ACPI tables for TP

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 05:37:26PM +0200, Laszlo Ersek wrote: > On 07/30/14 17:10, Stefan Berger wrote: > > Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: > > > >> From: Laszlo Ersek > >> To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS > >> Cc: qemu-devel@nongnu.org, Stefan Berger > >>

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 11:29:36AM -0400, Stefan Berger wrote: > "Michael S. Tsirkin" wrote on 07/30/2014 11:20:41 AM: > > > From: "Michael S. Tsirkin" > > To: Stefan Berger/Watson/IBM@IBMUS > > Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan > > Berger > > Date: 07/30/2014 11:20 AM > > Subjec

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
Laszlo Ersek wrote on 07/30/2014 11:41:10 AM: > From: Laszlo Ersek > To: Stefan Berger/Watson/IBM@IBMUS, "Michael S. Tsirkin" > Cc: qemu-devel@nongnu.org, Stefan Berger > Date: 07/30/2014 11:41 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On 07/30/14 17:29, Stefan Berger wrote: >

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:29, Stefan Berger wrote: > "Michael S. Tsirkin" wrote on 07/30/2014 11:20:41 AM: > >> From: "Michael S. Tsirkin" >> To: Stefan Berger/Watson/IBM@IBMUS >> Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan >> Berger >> Date: 07/30/2014 11:20 AM >> Subject: Re: [PATCH v2] Add ACPI ta

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 05:15:37PM +0200, Laszlo Ersek wrote: > On 07/30/14 16:46, Michael S. Tsirkin wrote: > > On Wed, Jul 30, 2014 at 04:36:38PM +0200, Laszlo Ersek wrote: > >> On 07/30/14 15:20, Michael S. Tsirkin wrote: > >>> On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > >>>

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:10, Stefan Berger wrote: > Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: > >> From: Laszlo Ersek >> To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS >> Cc: qemu-devel@nongnu.org, Stefan Berger >> Date: 07/30/2014 10:36 AM >> Subject: Re: [PATCH v2] Add ACPI tables for TP

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 11:25:25 AM: > From: "Michael S. Tsirkin" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: ler...@redhat.com, qemu-devel@nongnu.org, Stefan Berger > > Date: 07/30/2014 11:25 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On Wed, Jul 30, 2014 at 11:

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 11:20:41 AM: > From: "Michael S. Tsirkin" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: Laszlo Ersek , qemu-devel@nongnu.org, Stefan > Berger > Date: 07/30/2014 11:20 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On Wed, Jul 30, 2014 at 11:10:2

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 17:03, Igor Mammedov wrote: > On Wed, 30 Jul 2014 16:36:38 +0200 > Laszlo Ersek wrote: > >> On 07/30/14 15:20, Michael S. Tsirkin wrote: >>> On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: From: Stefan Berger Add an SSDT ACPI table for the TPM device. >>

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 11:13:07AM -0400, Stefan Berger wrote: > "Michael S. Tsirkin" wrote on 07/30/2014 11:07:28 AM: > > > > > >If you need bios to allocate this memory, then we will > > > >need a new allocation type for this, add it to linker > > > >in bios and qemu. > > > > > > Why does the

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 11:10:27AM -0400, Stefan Berger wrote: > Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: > > > From: Laszlo Ersek > > To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS > > Cc: qemu-devel@nongnu.org, Stefan Berger > > Date: 07/30/2014 10:36 AM > > Subject: Re: [PATC

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 16:46, Michael S. Tsirkin wrote: > On Wed, Jul 30, 2014 at 04:36:38PM +0200, Laszlo Ersek wrote: >> On 07/30/14 15:20, Michael S. Tsirkin wrote: >>> On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: From: Stefan Berger Add an SSDT ACPI table for the TPM devi

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 11:07:28 AM: > > >If you need bios to allocate this memory, then we will > > >need a new allocation type for this, add it to linker > > >in bios and qemu. > > > > Why does the BIOS 'need' to allocate it? Why can it not just use the memory > > that QEMU

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
Laszlo Ersek wrote on 07/30/2014 10:36:38 AM: > From: Laszlo Ersek > To: "Michael S. Tsirkin" , Stefan Berger/Watson/IBM@IBMUS > Cc: qemu-devel@nongnu.org, Stefan Berger > Date: 07/30/2014 10:36 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On 07/30/14 15:20, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 10:54:20AM -0400, Stefan Berger wrote: > On 07/30/2014 09:20 AM, Michael S. Tsirkin wrote: > >On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > >>From: Stefan Berger > >> > >>Add an SSDT ACPI table for the TPM device. > >>Add a TCPA table for BIOS logging are

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Igor Mammedov
On Wed, 30 Jul 2014 16:36:38 +0200 Laszlo Ersek wrote: > On 07/30/14 15:20, Michael S. Tsirkin wrote: > > On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > >> From: Stefan Berger > >> > >> Add an SSDT ACPI table for the TPM device. > >> Add a TCPA table for BIOS logging area when

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
On 07/30/2014 09:20 AM, Michael S. Tsirkin wrote: On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trust

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Wed, Jul 30, 2014 at 04:36:38PM +0200, Laszlo Ersek wrote: > On 07/30/14 15:20, Michael S. Tsirkin wrote: > > On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > >> From: Stefan Berger > >> > >> Add an SSDT ACPI table for the TPM device. > >> Add a TCPA table for BIOS logging area

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Laszlo Ersek
On 07/30/14 15:20, Michael S. Tsirkin wrote: > On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: >> From: Stefan Berger >> >> Add an SSDT ACPI table for the TPM device. >> Add a TCPA table for BIOS logging area when a TPM is being used. >> >> The latter follows this spec here: >> >> h

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Stefan Berger
"Michael S. Tsirkin" wrote on 07/30/2014 07:17:27 AM: > From: "Michael S. Tsirkin" > To: Stefan Berger/Watson/IBM@IBMUS > Cc: qemu-devel@nongnu.org, Stefan Berger > Date: 07/30/2014 07:18 AM > Subject: Re: [PATCH v2] Add ACPI tables for TPM > > On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > From: Stefan Berger > > Add an SSDT ACPI table for the TPM device. > Add a TCPA table for BIOS logging area when a TPM is being used. > > The latter follows this spec here: > > http://www.trustedcomputinggroup.org/files/static_pag

Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-30 Thread Michael S. Tsirkin
On Tue, Jul 29, 2014 at 06:52:19AM -0400, Stefan Berger wrote: > From: Stefan Berger > > Add an SSDT ACPI table for the TPM device. > Add a TCPA table for BIOS logging area when a TPM is being used. > > The latter follows this spec here: > > http://www.trustedcomputinggroup.org/files/static_pag

[Qemu-devel] [PATCH v2] Add ACPI tables for TPM

2014-07-29 Thread Stefan Berger
From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trustedcomputinggroup.org/files/static_page_files/DCD4188E-1A4B-B294-D050A155FB6F7385/TCG_ACPIGeneralSpecification_Public