Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-13 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: > +static void qmp_input_type_int(Visiter *v, int64_t *obj, const char *name, > Error **errp) > +{ > +QmpInputVisiter *qiv = to_qiv(v); > +QObject *qobj = qmp_input_get_object(qiv, name); > + > +if (!qobj || qobject_type(qobj) !=

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Anthony Liguori
On 06/09/2011 11:41 AM, Michael Roth wrote: On 06/09/2011 11:26 AM, Peter Maydell wrote: On 3 June 2011 23:33, Michael Roth wrote: A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 10:55 AM, Luiz Capitulino wrote: On Thu, 09 Jun 2011 10:41:53 -0500 Michael Roth wrote: On 06/09/2011 10:30 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: A type of Visiter class that is used to walk a qobject's structure and assign each en

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 11:26 AM, Peter Maydell wrote: On 3 June 2011 23:33, Michael Roth wrote: A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches), please? -- PMM Stefan pointed that out

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Peter Maydell
On 3 June 2011 23:33, Michael Roth wrote: > A type of Visiter class [randomly noted against this patch because this is where I happened to notice it...] Should be "Visitor" throughout (and in other patches), please? -- PMM

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Luiz Capitulino
On Thu, 09 Jun 2011 10:41:53 -0500 Michael Roth wrote: > On 06/09/2011 10:30 AM, Luiz Capitulino wrote: > > On Fri, 3 Jun 2011 17:33:08 -0500 > > Michael Roth wrote: > > > >> A type of Visiter class that is used to walk a qobject's > >> structure and assign each entry to the corresponding nativ

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Michael Roth
On 06/09/2011 10:30 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command p

Re: [Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-09 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:33:08 -0500 Michael Roth wrote: > A type of Visiter class that is used to walk a qobject's > structure and assign each entry to the corresponding native C type. > Command marshaling function will use this to pull out QMP command > parameters recieved over the wire and pass

[Qemu-devel] [PATCH v2][ 10/21] qapi: add QMP input visiter

2011-06-03 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions. Signe