Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-07 Thread Fam Zheng
On Fri, 02/07 12:14, Michael Tokarev wrote: > 07.02.2014 11:13, Paolo Bonzini wrote: > > Il 07/02/2014 01:06, Peter Maydell ha scritto: > >> Why do we need OS specific code to do this when the code > >> in vl.c for getting the executable path to use as a base for > >> finding bios blobs works fine

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-07 Thread Paolo Bonzini
Il 07/02/2014 09:14, Michael Tokarev ha scritto: 07.02.2014 11:13, Paolo Bonzini wrote: > Il 07/02/2014 01:06, Peter Maydell ha scritto: >> Why do we need OS specific code to do this when the code >> in vl.c for getting the executable path to use as a base for >> finding bios blobs works fine w

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-07 Thread Michael Tokarev
07.02.2014 11:13, Paolo Bonzini wrote: > Il 07/02/2014 01:06, Peter Maydell ha scritto: >> Why do we need OS specific code to do this when the code >> in vl.c for getting the executable path to use as a base for >> finding bios blobs works fine without OS specific code? > > That's because right no

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Paolo Bonzini
Il 07/02/2014 01:06, Peter Maydell ha scritto: Why do we need OS specific code to do this when the code in vl.c for getting the executable path to use as a base for finding bios blobs works fine without OS specific code? That's because right now module_call_init is not receiving an argv[0] to

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Peter Maydell
On 6 February 2014 23:38, Paolo Bonzini wrote: >> Looks like we're not getting the executable path >> correctly on MacOS for some reason. > > Indeed, there is no code for it. Can you try the patch below? > >> Also, mjt pointed out on IRC that we probably want to allow >> installing binary modules

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-06 Thread Paolo Bonzini
> Looks like we're not getting the executable path > correctly on MacOS for some reason. Indeed, there is no code for it. Can you try the patch below? > Also, mjt pointed out on IRC that we probably want to allow > installing binary modules into a path with the arch name in > it, to allow for mu

Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-02-05 Thread Peter Maydell
On 31 January 2014 14:49, Paolo Bonzini wrote: > Yet another rebase of the loadable module series, with the > following changes: > > 1) reworked a bit the build system magic so that "make foo.o" will pick > the right flags when foo.o is part of a module. > > 2) redid the split between patches 6/7/

[Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-01-31 Thread Paolo Bonzini
Yet another rebase of the loadable module series, with the following changes: 1) reworked a bit the build system magic so that "make foo.o" will pick the right flags when foo.o is part of a module. 2) redid the split between patches 6/7/9, doing first the makefile rules, then the C code to load t