Re: [Qemu-devel] [PATCH v17 1/6] lib/xbitmap: Introduce xbitmap

2017-11-06 Thread Wei Wang
On 11/03/2017 06:55 PM, Tetsuo Handa wrote: I'm commenting without understanding the logic. Wei Wang wrote: + +bool xb_preload(gfp_t gfp); + Want __must_check annotation, for __radix_tree_preload() is marked with __must_check annotation. By error failing to check result of xb_preload() will le

Re: [Qemu-devel] [PATCH v17 1/6] lib/xbitmap: Introduce xbitmap

2017-11-03 Thread Tetsuo Handa
I'm commenting without understanding the logic. Wei Wang wrote: > + > +bool xb_preload(gfp_t gfp); > + Want __must_check annotation, for __radix_tree_preload() is marked with __must_check annotation. By error failing to check result of xb_preload() will lead to preemption kept disabled unexpected

[Qemu-devel] [PATCH v17 1/6] lib/xbitmap: Introduce xbitmap

2017-11-03 Thread Wei Wang
From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits, and this commit adds the bare bones -- xb_set_bit(), xb_clear_bit(), xb_clear_bit_range(), xb_test_bit(), xb_find_n