Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2016 02:50 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> In the QMP input visitor, visiting a list traverses two objects: >>> the QAPI GenericList of the caller (which gets advanced in >>> visit_next_list() regardless of this patch), and the QList input

Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Eric Blake
On 04/29/2016 02:50 AM, Markus Armbruster wrote: > Eric Blake writes: > >> In the QMP input visitor, visiting a list traverses two objects: >> the QAPI GenericList of the caller (which gets advanced in >> visit_next_list() regardless of this patch), and the QList input >> that we are converting t

Re: [Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > In the QMP input visitor, visiting a list traverses two objects: > the QAPI GenericList of the caller (which gets advanced in > visit_next_list() regardless of this patch), and the QList input > that we are converting to QAPI. For consistency with QDict > visits, we want to

[Qemu-devel] [PATCH v16 11/24] qmp-input: Refactor when list is advanced

2016-04-28 Thread Eric Blake
In the QMP input visitor, visiting a list traverses two objects: the QAPI GenericList of the caller (which gets advanced in visit_next_list() regardless of this patch), and the QList input that we are converting to QAPI. For consistency with QDict visits, we want to consume elements from the input