Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-11-02 Thread Pradeep Jagadeesh
On 11/2/2017 12:00 PM, Alberto Garcia wrote: On Thu 02 Nov 2017 11:55:26 AM CET, Pradeep Jagadeesh wrote: -if (arg->has_iops_rd_max_length) { -cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length; -} -if (arg->has_iops_wr_max_length) { -cfg.buckets[T

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-11-02 Thread Alberto Garcia
On Thu 02 Nov 2017 11:55:26 AM CET, Pradeep Jagadeesh wrote: >>> -if (arg->has_iops_rd_max_length) { >>> -cfg.buckets[THROTTLE_OPS_READ].burst_length = >>> arg->iops_rd_max_length; >>> -} >>> -if (arg->has_iops_wr_max_length) { >>> -cfg.buckets[THROTTLE_OPS_WRITE].burs

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-11-02 Thread Pradeep Jagadeesh
On 10/13/2017 4:29 PM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:29 PM CEST, Pradeep Jagadeesh wrote: -if (arg->has_iops_rd_max_length) { -cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length; -} -if (arg->has_iops_wr_max_length) { -cfg.buckets[

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-10-13 Thread Alberto Garcia
On Mon 02 Oct 2017 04:33:29 PM CEST, Pradeep Jagadeesh wrote: > -if (arg->has_iops_rd_max_length) { > -cfg.buckets[THROTTLE_OPS_READ].burst_length = > arg->iops_rd_max_length; > -} > -if (arg->has_iops_wr_max_length) { > -cfg.buckets[THROTTLE_OPS_WRITE].burst_length =