Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-28 Thread Eric Blake
On 06/28/2012 06:06 AM, Max Filippov wrote: > On Wed, Jun 27, 2012 at 8:55 PM, Eric Blake wrote: >> On 06/27/2012 04:34 AM, Orit Wasserman wrote: > >> if (!is_power_of_2(num_pages)) { >>num_pages |= num_pages >> 1; >>num_pages |= num_pages >> 2; >>num_pages |= num_pages >> 4; >>n

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-28 Thread Max Filippov
On Wed, Jun 27, 2012 at 8:55 PM, Eric Blake wrote: > On 06/27/2012 04:34 AM, Orit Wasserman wrote: [...] >> + >> +    /* round down to the nearest power of 2 */ >> +    if (!is_power_of_2(num_pages)) { >> +        num_pages = 1 << ffs(num_pages); > > That's not how you round down.  For example,

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-28 Thread Orit Wasserman
On 06/27/2012 07:55 PM, Eric Blake wrote: > On 06/27/2012 04:34 AM, Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserma

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- >  Makefile.objs        |    1

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Orit Wasserman
On 06/27/2012 07:55 PM, Eric Blake wrote: > On 06/27/2012 04:34 AM, Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserma

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Eric Blake
On 06/27/2012 04:34 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +++ b/cache.c cache.c is a rather generic n

[Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs|1 + cache.c | 217 +++