Re: [Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Fam Zheng
On Thu, 10/10 15:40, Paolo Bonzini wrote: > Il 10/10/2013 14:34, Fam Zheng ha scritto: > > Hmm, basically an analogue to bindir and libdir. > > > > I'm not sure why wasn't that libdir/bindir always be ${prefix}/lib and > > ${prefix}/bin as well. So why are they needed? > > > > AFAICT it is not a

Re: [Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Paolo Bonzini
Il 10/10/2013 14:34, Fam Zheng ha scritto: > Hmm, basically an analogue to bindir and libdir. > > I'm not sure why wasn't that libdir/bindir always be ${prefix}/lib and > ${prefix}/bin as well. So why are they needed? > > AFAICT it is not a problem to drop it, if you insist. libdir can be ${pref

Re: [Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Fam Zheng
On Thu, 10/10 14:16, Paolo Bonzini wrote: > Il 10/10/2013 13:26, Fam Zheng ha scritto: > > This patch adds loading, stamp checking and initialization of modules. > > > > The init function of dynamic module is no longer directly called as > > __attribute__((constructor)) in static linked version, i

Re: [Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Paolo Bonzini
Il 10/10/2013 13:26, Fam Zheng ha scritto: > This patch adds loading, stamp checking and initialization of modules. > > The init function of dynamic module is no longer directly called as > __attribute__((constructor)) in static linked version, it is called > only after passed the checking of pres

[Qemu-devel] [PATCH v12 5/8] module: implement module loading

2013-10-10 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$(date +%s$$$RA