Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread Eric Blake
On 02/02/2016 05:25 AM, James Hogan wrote: > Hi Eric, > > On 18 November 2015 at 08:52, Eric Blake wrote: >> +# An enumeration of cpu types that enable additional information during >> +# @query-cpus. >> +# >> +# Since: 2.6 >> +## >> +{ 'enum': 'CpuInfoArch', >> + 'data': ['x86', 'sparc', 'ppc',

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread Markus Armbruster
James Hogan writes: > Hi Eric, > > On 18 November 2015 at 08:52, Eric Blake wrote: >> +# An enumeration of cpu types that enable additional information during >> +# @query-cpus. >> +# >> +# Since: 2.6 >> +## >> +{ 'enum': 'CpuInfoArch', >> + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'o

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread James Hogan
Hi Eric, On 18 November 2015 at 08:52, Eric Blake wrote: > +# An enumeration of cpu types that enable additional information during > +# @query-cpus. > +# > +# Since: 2.6 > +## > +{ 'enum': 'CpuInfoArch', > + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] } > + ... > +## > +# @Cp

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > On 11/19/2015 09:12 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The CpuInfo struct is used only by the 'query-cpus' output >>> command, so we are free to modify it by adding fields (clients >>> are already supposed to ignore unknown output fields), or by >>> c

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Eric Blake
On 11/19/2015 09:12 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The CpuInfo struct is used only by the 'query-cpus' output >> command, so we are free to modify it by adding fields (clients >> are already supposed to ignore unknown output fields), or by >> changing optional members to m

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > The CpuInfo struct is used only by the 'query-cpus' output > command, so we are free to modify it by adding fields (clients > are already supposed to ignore unknown output fields), or by > changing optional members to mandatory, while still keeping > QMP wire compatibility wi

[Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-18 Thread Eric Blake
The CpuInfo struct is used only by the 'query-cpus' output command, so we are free to modify it by adding fields (clients are already supposed to ignore unknown output fields), or by changing optional members to mandatory, while still keeping QMP wire compatibility with older versions of qemu. Whe