Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Benoît Canet
The Wednesday 07 May 2014 à 21:44:06 (+0200), Markus Armbruster wrote : > Eric Blake writes: > > > On 05/06/2014 07:27 AM, Luiz Capitulino wrote: > >> On Tue, 6 May 2014 15:07:40 +0200 > >> Benoît Canet wrote: > >> > >>> I am trying to use this series to modularise the block API. > >>> > >>> He

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Markus Armbruster
Eric Blake writes: > On 05/06/2014 07:27 AM, Luiz Capitulino wrote: >> On Tue, 6 May 2014 15:07:40 +0200 >> Benoît Canet wrote: >> >>> I am trying to use this series to modularise the block API. >>> >>> Here are my finding. >>> >>> I tried to make a qmp/block.json including VM state related API

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 19:20:14 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Wed, 07 May 2014 19:07:56 +0200 > > Lluís Vilanova wrote: > > >> Luiz Capitulino writes: > >> > >> > On Mon, 5 May 2014 14:21:26 -0400 > >> > Luiz Capitulino wrote: > >> > >> >> On Fri, 2 May 2014 1

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Lluís Vilanova
Luiz Capitulino writes: > On Wed, 07 May 2014 19:07:56 +0200 > Lluís Vilanova wrote: >> Luiz Capitulino writes: >> >> > On Mon, 5 May 2014 14:21:26 -0400 >> > Luiz Capitulino wrote: >> >> >> On Fri, 2 May 2014 15:52:19 +0200 >> >> Lluís Vilanova wrote: >> >> >> >> > Adds an include primiti

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Wed, 07 May 2014 19:07:56 +0200 Lluís Vilanova wrote: > Luiz Capitulino writes: > > > On Mon, 5 May 2014 14:21:26 -0400 > > Luiz Capitulino wrote: > > >> On Fri, 2 May 2014 15:52:19 +0200 > >> Lluís Vilanova wrote: > >> > >> > Adds an include primitive to the syntax of QAPI schema files,

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Lluís Vilanova
Luiz Capitulino writes: > On Mon, 5 May 2014 14:21:26 -0400 > Luiz Capitulino wrote: >> On Fri, 2 May 2014 15:52:19 +0200 >> Lluís Vilanova wrote: >> >> > Adds an include primitive to the syntax of QAPI schema files, allowing >> > these to >> > be modularized into multiple per-topic files in

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-07 Thread Luiz Capitulino
On Mon, 5 May 2014 14:21:26 -0400 Luiz Capitulino wrote: > On Fri, 2 May 2014 15:52:19 +0200 > Lluís Vilanova wrote: > > > Adds an include primitive to the syntax of QAPI schema files, allowing > > these to > > be modularized into multiple per-topic files in the future. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Eric Blake
On 05/06/2014 10:55 AM, Luiz Capitulino wrote: > On Tue, 06 May 2014 08:55:52 -0600 > Eric Blake wrote: > >>> Eventually, we might want to have if/defs and whatnot. But having a master >>> file seems a reasonable first step to me. I actually thought this was the >>> intention. Unless I got it wro

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Luiz Capitulino
On Tue, 06 May 2014 08:55:52 -0600 Eric Blake wrote: > > Eventually, we might want to have if/defs and whatnot. But having a master > > file seems a reasonable first step to me. I actually thought this was the > > intention. Unless I got it wrong, of course. > > Ifdefs may be a bit much. If we

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Eric Blake
On 05/06/2014 07:07 AM, Benoît Canet wrote: > > common.json being included in block-core.json and in qapi-schema.json it > quickly lead some code being generated in double and the compilation to choke. > > What do you think would be the best solution to fix this ? > (Fix the generator ? Make incl

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Eric Blake
On 05/06/2014 07:27 AM, Luiz Capitulino wrote: > On Tue, 6 May 2014 15:07:40 +0200 > Benoît Canet wrote: > >> I am trying to use this series to modularise the block API. >> >> Here are my finding. >> >> I tried to make a qmp/block.json including VM state related API. >> block.json include a qmp/b

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Benoît Canet
The Tuesday 06 May 2014 à 09:27:25 (-0400), Luiz Capitulino wrote : > On Tue, 6 May 2014 15:07:40 +0200 > Benoît Canet wrote: > > > I am trying to use this series to modularise the block API. > > > > Here are my finding. > > > > I tried to make a qmp/block.json including VM state related API. >

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Luiz Capitulino
On Tue, 6 May 2014 15:07:40 +0200 Benoît Canet wrote: > I am trying to use this series to modularise the block API. > > Here are my finding. > > I tried to make a qmp/block.json including VM state related API. > block.json include a qmp/block-core.json containing only true block stuff. > > Whe

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-06 Thread Benoît Canet
The Friday 02 May 2014 à 15:52:19 (+0200), Lluís Vilanova wrote : Hello, I am trying to use this series to modularise the block API. Here are my finding. I tried to make a qmp/block.json including VM state related API. block.json include a qmp/block-core.json containing only true block stuff.

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-05 Thread Luiz Capitulino
On Fri, 2 May 2014 15:52:19 +0200 Lluís Vilanova wrote: > Adds an include primitive to the syntax of QAPI schema files, allowing these > to > be modularized into multiple per-topic files in the future. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbrust

[Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-02 Thread Lluís Vilanova
Adds an include primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- Changes in v12: * Fix "Reviewed-by" lines. Changes in v11: * R