Re: [Qemu-devel] [PATCH v11 6/7] vhost-user: add multiple queue support

2015-09-23 Thread Jason Wang
On 09/24/2015 01:57 PM, Yuanhan Liu wrote: > On Thu, Sep 24, 2015 at 01:34:31PM +0800, Jason Wang wrote: >> >> Some nitpicks and comments. If you plan to send another version, please >> consider to fix them. > I will, but I'd like to hold a while before getting more comments from > Michael; I don

Re: [Qemu-devel] [PATCH v11 6/7] vhost-user: add multiple queue support

2015-09-23 Thread Yuanhan Liu
On Thu, Sep 24, 2015 at 01:34:31PM +0800, Jason Wang wrote: > > > Some nitpicks and comments. If you plan to send another version, please > consider to fix them. I will, but I'd like to hold a while before getting more comments from Michael; I don't want to repost a whole new version too often f

Re: [Qemu-devel] [PATCH v11 6/7] vhost-user: add multiple queue support

2015-09-23 Thread Jason Wang
On 09/23/2015 02:56 PM, Yuanhan Liu wrote: > On Wed, Sep 23, 2015 at 12:20:00PM +0800, Yuanhan Liu wrote: >> From: Changchun Ouyang >> > [...] >> static void net_vhost_user_event(void *opaque, int event) >> { >> -VhostUserState *s = opaque; >> +const char *name = opaque; >> +NetCli

Re: [Qemu-devel] [PATCH v11 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Yuanhan Liu
On Wed, Sep 23, 2015 at 12:20:00PM +0800, Yuanhan Liu wrote: > From: Changchun Ouyang > [...] > static void net_vhost_user_event(void *opaque, int event) > { > -VhostUserState *s = opaque; > +const char *name = opaque; > +NetClientState *ncs[MAX_QUEUE_NUM]; > +VhostUserState *s;

[Qemu-devel] [PATCH v11 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Yuanhan Liu
From: Changchun Ouyang This patch is initially based a patch from Nikolay Nikolaev. This patch adds vhost-user multiple queue support, by creating a nc and vhost_net pair for each queue. Qemu exits if find that the backend can't support the number of requested queues (by providing queues=# opti