Re: [Qemu-devel] [PATCH v11 28/28] qapi: Detect base class loops

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > It should be fairly obvious that qapi base classes need to > form an acyclic graph, since QMP cannot specify the same > key more than once, while base classes are included as flat > members alongside other members added by the child. But the > old check_member_clash() parser

[Qemu-devel] [PATCH v11 28/28] qapi: Detect base class loops

2015-11-10 Thread Eric Blake
It should be fairly obvious that qapi base classes need to form an acyclic graph, since QMP cannot specify the same key more than once, while base classes are included as flat members alongside other members added by the child. But the old check_member_clash() parser function was not prepared to c