Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > On 11/12/2015 08:11 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> None of the visitor callbacks would set an error when testing >>> if an optional field was present; make this part of the interface >>> contract by eliminating the errp argument. Then, for less c

Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Eric Blake
On 11/12/2015 08:11 AM, Markus Armbruster wrote: > Eric Blake writes: > >> None of the visitor callbacks would set an error when testing >> if an optional field was present; make this part of the interface >> contract by eliminating the errp argument. Then, for less code, >> reflect the determin

Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > None of the visitor callbacks would set an error when testing > if an optional field was present; make this part of the interface > contract by eliminating the errp argument. Then, for less code, > reflect the determined boolean value back to the caller instead > of making t

[Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-10 Thread Eric Blake
None of the visitor callbacks would set an error when testing if an optional field was present; make this part of the interface contract by eliminating the errp argument. Then, for less code, reflect the determined boolean value back to the caller instead of making the caller read the boolean afte