Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Eric Blake
On 2/5/19 8:28 AM, Kevin Wolf wrote: >> How about the following: >> >> @in-use: This flag is set while bitmap is in use by software and it's data in >> qcow2 image may be out of date when actual bitmap data is managed by >> software. >> Presence of this flag in offline image means that bitmap was

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Kevin Wolf
Am 05.02.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.02.2019 13:00, Kevin Wolf wrote: > > Am 04.02.2019 um 16:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 04.02.2019 16:45, Markus Armbruster wrote: > >>> Kevin Wolf writes: > >>> > Am 01.02.2019 um 19:39 hat Marku

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2019 13:00, Kevin Wolf wrote: > Am 04.02.2019 um 16:36 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 04.02.2019 16:45, Markus Armbruster wrote: >>> Kevin Wolf writes: >>> Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: > Andrey Shinkevich writes: > >> In the 'F

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-05 Thread Kevin Wolf
Am 04.02.2019 um 16:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2019 16:45, Markus Armbruster wrote: > > Kevin Wolf writes: > > > >> Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: > >>> Andrey Shinkevich writes: > >>> > In the 'Format specific information' section of

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Eric Blake
On 2/4/19 10:46 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> Oops, hm, I now doubt, how Andrey's patches work, if bitmap_list_load >> function >> fails when unknown flags are found. So, can we really show unknown-flags, >> or we'll fail if there any? >> >> And if we fail (I hope we fail) on unkn

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Eric Blake
On 2/4/19 11:33 AM, Eric Blake wrote: > On 2/4/19 10:46 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> >>> Oops, hm, I now doubt, how Andrey's patches work, if bitmap_list_load >>> function >>> fails when unknown flags are found. So, can we really show unknown-flags, >>> or we'll fail if there any

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2019 19:35, Vladimir Sementsov-Ogievskiy wrote: > 04.02.2019 19:24, Eric Blake wrote: >> On 2/4/19 10:03 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> What would QMP clients do with this information? > > 'qemu-img info' is the intended QMP client; and it will print the > unkno

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2019 19:24, Eric Blake wrote: > On 2/4/19 10:03 AM, Vladimir Sementsov-Ogievskiy wrote: > > What would QMP clients do with this information? 'qemu-img info' is the intended QMP client; and it will print the unknown-flags along with everything else. In other words, we're tr

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Eric Blake
On 2/4/19 10:03 AM, Vladimir Sementsov-Ogievskiy wrote: What would QMP clients do with this information? >>> >>> 'qemu-img info' is the intended QMP client; and it will print the >>> unknown-flags along with everything else. In other words, we're trying >>> to make qemu-img become useful for

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2019 16:05, Markus Armbruster wrote: > Eric Blake writes: > >> On 2/1/19 1:23 PM, Markus Armbruster wrote: >> >> +# @unknown-flags: any remaining flags not recognized by the current >> qemu version > > Intended use cases for @unknown-flags? The qcow2 spec defines

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2019 16:45, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: >>> Andrey Shinkevich writes: >>> In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existi

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Eric Blake
On 2/4/19 1:49 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +++ b/qapi/block-core.json >>> ## >>> +# @Qcow2BitmapInfoFlags: >>> +# >>> +# An enumeration of flags that a bitmap can report to the user. >>> +# >>> +# @in-use: The bitmap was not saved correctly and may be inconsistent. >> >> I doubt

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: >> Andrey Shinkevich writes: >> >> > In the 'Format specific information' section of the 'qemu-img info' >> > command output, the supplemental information about existing QCOW2 >> > bitmaps will be shown, such as a bi

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Markus Armbruster
Eric Blake writes: > On 2/1/19 1:23 PM, Markus Armbruster wrote: > > +# @unknown-flags: any remaining flags not recognized by the current qemu > version Intended use cases for @unknown-flags? >>> >>> The qcow2 spec defines bit 2 extra_data_compatible; and also leaves the >>> do

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-04 Thread Kevin Wolf
Am 01.02.2019 um 19:39 hat Markus Armbruster geschrieben: > Andrey Shinkevich writes: > > > In the 'Format specific information' section of the 'qemu-img info' > > command output, the supplemental information about existing QCOW2 > > bitmaps will be shown, such as a bitmap name, flags and granula

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-03 Thread Vladimir Sementsov-Ogievskiy
01.02.2019 21:39, Markus Armbruster wrote: > Andrey Shinkevich writes: > >> In the 'Format specific information' section of the 'qemu-img info' >> command output, the supplemental information about existing QCOW2 >> bitmaps will be shown, such as a bitmap name, flags and granularity: >> >> image:

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 2/1/19 1:23 PM, Markus Armbruster wrote: +# @unknown-flags: any remaining flags not recognized by the current qemu version >>> >>> Intended use cases for @unknown-flags? >> >> The qcow2 spec defines bit 2 extra_data_compatible; and also leaves the >> door open for future extensions t

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Markus Armbruster
Eric Blake writes: > On 2/1/19 12:39 PM, Markus Armbruster wrote: >> Andrey Shinkevich writes: >> > >>> >>> ## >>> +# @Qcow2BitmapInfoFlags: >>> +# >>> +# An enumeration of flags that a bitmap can report to the user. >>> +# >>> +# @in-use: The bitmap was not saved correctly and may be incons

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 2/1/19 12:39 PM, Markus Armbruster wrote: > Andrey Shinkevich writes: > >> >> ## >> +# @Qcow2BitmapInfoFlags: >> +# >> +# An enumeration of flags that a bitmap can report to the user. >> +# >> +# @in-use: The bitmap was not saved correctly and may be inconsistent. > > I doubt the casual r

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Markus Armbruster
Andrey Shinkevich writes: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > image: /vz/vmprivate/VM1/harddisk.hdd > file format: qcow2

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Kevin Wolf
Am 31.01.2019 um 14:46 hat Andrey Shinkevich geschrieben: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > image: /vz/vmprivate/VM1/ha

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 1/31/19 7:46 AM, Andrey Shinkevich wrote: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > + > +static Qcow2BitmapInfoFlagsList *g

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Vladimir Sementsov-Ogievskiy
31.01.2019 16:46, Andrey Shinkevich wrote: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > image: /vz/vmprivate/VM1/harddisk.hdd > fi

[Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-01-31 Thread Andrey Shinkevich
In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existing QCOW2 bitmaps will be shown, such as a bitmap name, flags and granularity: image: /vz/vmprivate/VM1/harddisk.hdd file format: qcow2 virtual size: 64G (68719476736 bytes)