Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Michael R. Hines
On 06/25/2013 12:31 PM, Vasilis Liaskovitis wrote: Hi, On Mon, Jun 24, 2013 at 09:58:01PM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" [...] +/* + * Put in the log file which RDMA device was opened and the details + * associated with that device. + */ +static void qemu_

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 18:31, Vasilis Liaskovitis ha scritto: > Then I think qemu_rdma_dump_id can segfault trying to dereference a null verbs > structure. The dump_id function should check for non-NULL verbs argument, > or the dump should be made only in the (verbs != NULL) if clause. > > Disabling the du

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Vasilis Liaskovitis
Hi, On Mon, Jun 24, 2013 at 09:58:01PM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > [...] > +/* > + * Put in the log file which RDMA device was opened and the details > + * associated with that device. > + */ > +static void qemu_rdma_dump_id(const char *who, struct ibv_co

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Michael R. Hines
On 06/25/2013 08:05 AM, Juan Quintela wrote: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch. This file includes the entire protocol and interfaces

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Juan Quintela
mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Code that does need to be visible is kept > well contained inside this file and this is the only > new additional file to the entire patch. > > This file includes the entire protocol and interfaces > required to perform RDMA migratio