Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-17 Thread Orit Wasserman
On 05/17/2012 12:46 PM, Avi Kivity wrote: > On 05/16/2012 08:58 PM, Eric Blake wrote: >> On 05/16/2012 11:04 AM, Orit Wasserman wrote: >> > +- "value": cache size in bytes (json-int) Would it be any easier to take 'order' (log2 of the size) instead of the actual cache size? That

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-17 Thread Avi Kivity
On 05/16/2012 08:58 PM, Eric Blake wrote: > On 05/16/2012 11:04 AM, Orit Wasserman wrote: > > >>> +- "value": cache size in bytes (json-int) > >> > >> Would it be any easier to take 'order' (log2 of the size) instead of the > >> actual cache size? That is, instead of calling "value":1048576, I wou

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Eric Blake
On 05/16/2012 05:59 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by:

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Eric Blake
On 05/16/2012 11:04 AM, Orit Wasserman wrote: >>> +- "value": cache size in bytes (json-int) >> >> Would it be any easier to take 'order' (log2 of the size) instead of the >> actual cache size? That is, instead of calling "value":1048576, I would >> rather type "value":20. > Well the user is cons

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Orit Wasserman
On 05/16/2012 07:45 PM, Eric Blake wrote: > On 05/16/2012 05:59 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >

[Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c |7 +++ hmp-c