Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 14:12, Aleksandar Rikalo a écrit : > Hi Laurent, ... >> BTW, do we really need to emulate the syscall if it is not available? >> >> I think the user-space application calling statx() should be ready to >> receive ENOSYS and define some kinds of fallback (like you do below). So >> it

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-19 Thread Aleksandar Rikalo
Hi Laurent, > s/arhitecture/architecture/ Done. > You should define sys_statx() using _syscall5() macro and use it. Done. > ret != -TARGET_ENOSYS Done. > You already checked above p is not NULL and exited with -TARGET_EFAULT. Done. > BTW, do we really need to emulate the syscall if it is n

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-18 Thread Jim Wilson
On Tue, Jun 18, 2019 at 4:13 PM Aleksandar Markovic wrote: > I am waiting on him to send a new version of the series. Meanwhile you can > send strace patch to the list, and I can even incude it in my series after > and together with Aleksandar's patch, if you don't object. I submitted it the us

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-18 Thread Aleksandar Markovic
On Wednesday, June 19, 2019, Jim Wilson wrote: > On 6/7/19 3:35 AM, Aleksandar Markovic wrote: > >> Implement support for translation of system call statx(). >> > > I also need these patches for 32-bit RISC-V linux user mode support. > > glibc ld.so calls statx if fstatat is not supported. Appar

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-18 Thread Jim Wilson
On 6/7/19 3:35 AM, Aleksandar Markovic wrote: Implement support for translation of system call statx(). I also need these patches for 32-bit RISC-V linux user mode support. glibc ld.so calls statx if fstatat is not supported. Apparently new linux architecture ports aren't allowed to define _

Re: [Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-13 Thread Laurent Vivier
Le 07/06/2019 à 12:35, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Implement support for translation of system call statx(). > > The implementation is based on "best effort" approach: if host is > capable of executing statx(), host statx() is used. If not, the > implementation in

[Qemu-devel] [PATCH v10 3/3] linux-user: Add support for statx() syscall

2019-06-07 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation is based on "best effort" approach: if host is capable of executing statx(), host statx() is used. If not, the implementation includes invoking other (more mature) system calls (from the same 'st