Re: [Qemu-devel] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Fam Zheng
On Thu, 01/19 15:49, Daniel P. Berrange wrote: > On Thu, Jan 19, 2017 at 10:38:14PM +0800, Fam Zheng wrote: > > This implements open flag sensible image locking for local file > > and host device protocol. > > > > virtlockd in libvirt locks the first byte, so we start looking at the > > file bytes

Re: [Qemu-devel] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 10:38:14PM +0800, Fam Zheng wrote: > This implements open flag sensible image locking for local file > and host device protocol. > > virtlockd in libvirt locks the first byte, so we start looking at the > file bytes from 1. > > Quoting what was proposed by Kevin Wolf , the

[Qemu-devel] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Fam Zheng
This implements open flag sensible image locking for local file and host device protocol. virtlockd in libvirt locks the first byte, so we start looking at the file bytes from 1. Quoting what was proposed by Kevin Wolf , there are four locking modes by combining two bits (BDRV_O_RDWR and BDRV_O_S