Re: [Qemu-devel] [PATCH v10 13/25] qapi-visit: Convert to new qapi union layout

2015-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/26/2015 11:07 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We have two issues with our qapi union layout: >>> 1) Even though the QMP wire format spells the tag 'type', the >>> C code spells it 'kind', requiring some hacks in the generator. >>> 2) The C st

Re: [Qemu-devel] [PATCH v10 13/25] qapi-visit: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
On 10/26/2015 11:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We have two issues with our qapi union layout: >> 1) Even though the QMP wire format spells the tag 'type', the >> C code spells it 'kind', requiring some hacks in the generator. >> 2) The C struct uses an anonymous union,

Re: [Qemu-devel] [PATCH v10 13/25] qapi-visit: Convert to new qapi union layout

2015-10-26 Thread Markus Armbruster
Eric Blake writes: > We have two issues with our qapi union layout: > 1) Even though the QMP wire format spells the tag 'type', the > C code spells it 'kind', requiring some hacks in the generator. > 2) The C struct uses an anonymous union, which places all tag > values in the same namespace as a

[Qemu-devel] [PATCH v10 13/25] qapi-visit: Convert to new qapi union layout

2015-10-22 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le