Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-05 Thread John Snow
On 11/05/2015 02:35 PM, Markus Armbruster wrote: > John Snow writes: > >> On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote: >>> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: > On Fri, Oct 23, 2015 at 07:56:50PM -0400, J

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-05 Thread Markus Armbruster
John Snow writes: > On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote: >> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: >>> >>> >>> On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > @@ -1732,6 +1757,10 @@ static void >>>

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-05 Thread John Snow
On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote: > On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: >> >> >> On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: >>> On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: @@ -1732,6 +1757,10 @@ static void block_dirty_bitmap_add_p

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-05 Thread Stefan Hajnoczi
On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: > > > On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: > > On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > >> @@ -1732,6 +1757,10 @@ static void > >> block_dirty_bitmap_add_prepare(BlkActionState *common, > >> BlockDirtyB

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-03 Thread Eric Blake
On 11/03/2015 10:31 AM, John Snow wrote: > > > On 11/03/2015 10:23 AM, Eric Blake wrote: >> On 10/23/2015 05:56 PM, John Snow wrote: >>> Add both transactional properties to the QMP transactional interface, >>> and add the BlockJobTxn that we create as a result of the err-cancel >>> property to t

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-03 Thread John Snow
On 11/03/2015 10:23 AM, Eric Blake wrote: > On 10/23/2015 05:56 PM, John Snow wrote: >> Add both transactional properties to the QMP transactional interface, >> and add the BlockJobTxn that we create as a result of the err-cancel >> property to the BlkActionState structure. >> >> [split up from a

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-03 Thread John Snow
On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: > On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: >> @@ -1732,6 +1757,10 @@ static void >> block_dirty_bitmap_add_prepare(BlkActionState *common, >> BlockDirtyBitmapState *state = DO_UPCAST(BlockDirtyBitmapState, >>

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-03 Thread Eric Blake
On 10/23/2015 05:56 PM, John Snow wrote: > Add both transactional properties to the QMP transactional interface, > and add the BlockJobTxn that we create as a result of the err-cancel > property to the BlkActionState structure. > > [split up from a patch originally by Stefan and Fam. --js] > Signe

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-11-03 Thread Stefan Hajnoczi
On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > @@ -1732,6 +1757,10 @@ static void > block_dirty_bitmap_add_prepare(BlkActionState *common, > BlockDirtyBitmapState *state = DO_UPCAST(BlockDirtyBitmapState, > common, common); > > +

[Qemu-devel] [PATCH v10 12/14] block: add transactional properties

2015-10-23 Thread John Snow
Add both transactional properties to the QMP transactional interface, and add the BlockJobTxn that we create as a result of the err-cancel property to the BlkActionState structure. [split up from a patch originally by Stefan and Fam. --js] Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng