Re: [Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-18 Thread Markus Armbruster
Eric Blake writes: > On 02/18/2016 01:51 AM, Markus Armbruster wrote: > >>> It gets renamed to is_unboxed after the review on 10/13. But even after >>> my patch to convert simple unions, this code will still be >>> c_type=typ.c_type(is_unboxed=True), unless I figure out a way to rework >>> .c_ty

Re: [Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-18 Thread Eric Blake
On 02/18/2016 01:51 AM, Markus Armbruster wrote: >> It gets renamed to is_unboxed after the review on 10/13. But even after >> my patch to convert simple unions, this code will still be >> c_type=typ.c_type(is_unboxed=True), unless I figure out a way to rework >> .c_type() to not need two separat

Re: [Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-18 Thread Markus Armbruster
Eric Blake writes: > On 02/17/2016 10:44 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> There's no reason to do two malloc's for a flat union; let's just >>> inline the branch struct directly into the C union branch of the >>> flat union. >>> >>> Surprisingly, fewer clients were actu

Re: [Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-17 Thread Eric Blake
On 02/17/2016 10:44 AM, Markus Armbruster wrote: > Eric Blake writes: > >> There's no reason to do two malloc's for a flat union; let's just >> inline the branch struct directly into the C union branch of the >> flat union. >> >> Surprisingly, fewer clients were actually using explicit references

Re: [Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-17 Thread Markus Armbruster
Eric Blake writes: > There's no reason to do two malloc's for a flat union; let's just > inline the branch struct directly into the C union branch of the > flat union. > > Surprisingly, fewer clients were actually using explicit references > to the branch types in comparison to the number of flat

[Qemu-devel] [PATCH v10 11/13] qapi: Don't box branches of flat unions

2016-02-15 Thread Eric Blake
There's no reason to do two malloc's for a flat union; let's just inline the branch struct directly into the C union branch of the flat union. Surprisingly, fewer clients were actually using explicit references to the branch types in comparison to the number of flat unions thus modified. This let