Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*

2015-11-06 Thread Eric Blake
On 11/06/2015 09:23 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/06/2015 08:40 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> By moving err into data, we can let test teardown take care of cleaning up any collected error; it also gives us fewer lines of co

Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*

2015-11-06 Thread Markus Armbruster
Eric Blake writes: > On 11/06/2015 08:40 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> By moving err into data, we can let test teardown take care >>> of cleaning up any collected error; it also gives us fewer >>> lines of code between repeated tests where init runs teardown >>> on

Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*

2015-11-06 Thread Eric Blake
On 11/06/2015 08:40 AM, Markus Armbruster wrote: > Eric Blake writes: > >> By moving err into data, we can let test teardown take care >> of cleaning up any collected error; it also gives us fewer >> lines of code between repeated tests where init runs teardown >> on our behalf. > > I think this

Re: [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*

2015-11-06 Thread Markus Armbruster
Eric Blake writes: > By moving err into data, we can let test teardown take care > of cleaning up any collected error; it also gives us fewer > lines of code between repeated tests where init runs teardown > on our behalf. I think this paragraph is no longer valid: you aren't moving err anywhere

[Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*

2015-11-05 Thread Eric Blake
By moving err into data, we can let test teardown take care of cleaning up any collected error; it also gives us fewer lines of code between repeated tests where init runs teardown on our behalf. Rather than duplicate code between .c files, I added a new test-qmp-common.h. I debated about putting