Re: [Qemu-devel] [PATCH v10 06/30] qapi: Simplify non-error testing in test-qmp-*

2015-11-06 Thread Markus Armbruster
Eric Blake writes: > On 11/06/2015 08:36 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> By using &error_abort, we can avoid a local err variable in >>> situations where we expect success. It also has the nice >>> effect that if the test breaks, the error message from >>> error_abort

Re: [Qemu-devel] [PATCH v10 06/30] qapi: Simplify non-error testing in test-qmp-*

2015-11-06 Thread Eric Blake
On 11/06/2015 08:36 AM, Markus Armbruster wrote: > Eric Blake writes: > >> By using &error_abort, we can avoid a local err variable in >> situations where we expect success. It also has the nice >> effect that if the test breaks, the error message from >> error_abort tends to be nicer than that

Re: [Qemu-devel] [PATCH v10 06/30] qapi: Simplify non-error testing in test-qmp-*

2015-11-06 Thread Markus Armbruster
Eric Blake writes: > By using &error_abort, we can avoid a local err variable in > situations where we expect success. It also has the nice > effect that if the test breaks, the error message from > error_abort tends to be nicer than that of g_assert(). > > Signed-off-by: Eric Blake [Boring mec

[Qemu-devel] [PATCH v10 06/30] qapi: Simplify non-error testing in test-qmp-*

2015-11-05 Thread Eric Blake
By using &error_abort, we can avoid a local err variable in situations where we expect success. It also has the nice effect that if the test breaks, the error message from error_abort tends to be nicer than that of g_assert(). Signed-off-by: Eric Blake --- v10: split into two pieces v9: move ea