Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

10.09.2019 13:14, Max Reitz wrote: > On 10.09.19 11:22, Vladimir Sementsov-Ogievskiy wrote: > > [...] > >> Ok, than >> >> 4. Postpone improvements for a follow-up (anyway, finally, block-copy should >> use block_status to copy by larger chunks, like mirror does), and improve the >> comment like t

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 10.09.19 11:22, Vladimir Sementsov-Ogievskiy wrote: [...] > Ok, than > > 4. Postpone improvements for a follow-up (anyway, finally, block-copy should > use block_status to copy by larger chunks, like mirror does), and improve the > comment like this: > > """ > Used for job sync=top mode, whi

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

10.09.2019 11:39, Max Reitz wrote: > On 10.09.19 10:12, Vladimir Sementsov-Ogievskiy wrote: >> 10.09.2019 10:42, Max Reitz wrote: >>> On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: 09.09.2019 17:24, Max Reitz wrote: > On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >> 09

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 10.09.19 10:12, Vladimir Sementsov-Ogievskiy wrote: > 10.09.2019 10:42, Max Reitz wrote: >> On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: >>> 09.09.2019 17:24, Max Reitz wrote: On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 15:59, Max Reitz wrote: >> On

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

10.09.2019 10:42, Max Reitz wrote: > On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: >> 09.09.2019 17:24, Max Reitz wrote: >>> On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: 09.09.2019 15:59, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> Sp

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 17:24, Max Reitz wrote: >> On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >>> 09.09.2019 15:59, Max Reitz wrote: On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "bloc

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

09.09.2019 17:24, Max Reitz wrote: > On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >> 09.09.2019 15:59, Max Reitz wrote: >>> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: Split copying code part from backup to "block-copy", including separate state structure and function

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 15:59, Max Reitz wrote: >> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >>> Split copying code part from backup to "block-copy", including separate >>> state structure and function renaming. This is needed to share it wit

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

09.09.2019 15:59, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> Split copying code part from backup to "block-copy", including separate >> state structure and function renaming. This is needed to share it with >> backup-top filter driver in further commits. >> >> Note

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "block-copy", including separate > state structure and function renaming. This is needed to share it with > backup-top filter driver in further commits. > > Notes: > > 1. As BlockCopyState keeps own Bl

[Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

Split copying code part from backup to "block-copy", including separate state structure and function renaming. This is needed to share it with backup-top filter driver in further commits. Notes: 1. As BlockCopyState keeps own BlockBackend objects, remaining job->common.blk users only use it to ge