Re: [Qemu-devel] [PATCH v10 04/13] qapi: Drop pointless gotos in generated code

2016-02-16 Thread Eric Blake
On 02/16/2016 09:27 AM, Markus Armbruster wrote: > Eric Blake writes: > >> There's no point in emitting a goto if the very next thing >> emitted will be the label. A bit of cleverness in gen_visit_fields() >> will let us choose when to omit a final error check (basically, >> swap the order of em

Re: [Qemu-devel] [PATCH v10 04/13] qapi: Drop pointless gotos in generated code

2016-02-16 Thread Markus Armbruster
Eric Blake writes: > There's no point in emitting a goto if the very next thing > emitted will be the label. A bit of cleverness in gen_visit_fields() > will let us choose when to omit a final error check (basically, > swap the order of emitted text within the loop, with the error > check omitte

[Qemu-devel] [PATCH v10 04/13] qapi: Drop pointless gotos in generated code

2016-02-15 Thread Eric Blake
There's no point in emitting a goto if the very next thing emitted will be the label. A bit of cleverness in gen_visit_fields() will let us choose when to omit a final error check (basically, swap the order of emitted text within the loop, with the error check omitted on the first pass, then check