Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-13 Thread Richard Henderson
On 07/13/2016 05:35 AM, Michael Rolnik wrote: > a. a helper function sets a flag within env ... and exits the cpu loop. > b. cpu_get_tb_cpu_state introduces this flag, though tb.flags, for code > generation by gen_intermediate_code > c. the code is generated Yep. > d. the flag remains to be se

Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-13 Thread Michael Rolnik
a. a helper function sets a flag within env b. cpu_get_tb_cpu_state introduces this flag, though tb.flags, for code generation by gen_intermediate_code c. the code is generated d. the flag remains to be set within env. Who clear it? On Wed, Jul 13, 2016 at 3:54 AM, Michael Rolnik wrote: > So how

Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-13 Thread Michael Rolnik
So how do I get this flag unset? On Wed, Jul 13, 2016, 12:17 AM Richard Henderson wrote: > On 07/12/2016 08:32 PM, Michael Rolnik wrote: > > Hi Richard, > > > > Please explain why I am not accessing fullacc correctly. > > You can't examine fields of env, which vary, during translate.c. > You mus

Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-13 Thread Richard Henderson
On 07/12/2016 08:32 PM, Michael Rolnik wrote: Hi Richard, Please explain why I am not accessing fullacc correctly. You can't examine fields of env, which vary, during translate.c. You must only examine fields of TB, which are invariant. r~

Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-12 Thread Michael Rolnik
Hi Richard, Please explain why I am not accessing fullacc correctly. On Tue, Jul 12, 2016 at 10:19 AM, Richard Henderson wrote: > On 07/06/2016 03:33 PM, Michael Rolnik wrote: > > +static bool avr_cpu_has_work(CPUState *cs) > > +{ > > +AVRCPU *cpu = AVR_CPU(cs); > > +CPUAVRState *env =

Re: [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-12 Thread Richard Henderson
On 07/06/2016 03:33 PM, Michael Rolnik wrote: > +static bool avr_cpu_has_work(CPUState *cs) > +{ > +AVRCPU *cpu = AVR_CPU(cs); > +CPUAVRState *env = &cpu->env; > + > +return (cs->interrupt_request > +& (CPU_INTERRUPT_HARD > +| CPU_INTERRUPT_RES

[Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added.

2016-07-06 Thread Michael Rolnik
1. basic CPU structure 2. registers 3. no instructions 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation saving cpu features Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/av