On Tue, Jun 20, 2017 at 10:48:22AM -0700, Richard Henderson wrote:
> On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote:
> >+int width = imm_w - imm_s + 1;
> >+
> >+if (width == 0 || imm_w <= imm_s) {
>
> The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It
> shou
On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote:
+int width = imm_w - imm_s + 1;
+
+if (width == 0 || imm_w <= imm_s) {
The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It
should be <.
If imm_w >= imm_s, as per the proper check, then width must be >= 1.
From: "Edgar E. Iglesias"
Add support for BSIFI.
Signed-off-by: Edgar E. Iglesias
---
target/microblaze/translate.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 4a8ab22..743b66f 100644
---