Re: [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes

2019-08-09 Thread Alistair Francis
On Thu, Aug 8, 2019 at 9:43 AM Alex Bennée wrote: > > We should avoid including the whole of softfloat headers in cpu.h and > explicitly include it only where we will be calling softfloat > functions. We can use the -types.h and -helpers.h in cpu.h for the few > bits that are global. > > Signed-of

Re: [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes

2019-08-08 Thread Richard Henderson
On 8/8/19 9:41 AM, Alex Bennée wrote: > We should avoid including the whole of softfloat headers in cpu.h and > explicitly include it only where we will be calling softfloat > functions. We can use the -types.h and -helpers.h in cpu.h for the few > bits that are global. > > Signed-off-by: Alex Ben

[Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes

2019-08-08 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and -helpers.h in cpu.h for the few bits that are global. Signed-off-by: Alex Bennée --- target/riscv/cpu.c| 1 + target/