Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 13:43, Andreas Färber ha scritto: > Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: >> > From: Peter Crosthwaite >> > >> > These comments we're a little difficult to read. First one had > While we're picky: "were" - Paolo can you fix up in your queue? Of course. Paolo

Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Andreas Färber
Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: > From: Peter Crosthwaite > > These comments we're a little difficult to read. First one had While we're picky: "were" - Paolo can you fix up in your queue? Andreas > incorrect parenthesis. The part about attributes changing is > reall

[Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-02 Thread peter . crosthwaite
From: Peter Crosthwaite These comments we're a little difficult to read. First one had incorrect parenthesis. The part about attributes changing is really applicable to the region being 'in both' rather than 'in new' Second comment has an obscure parenthetic about 'Logging may have changed'. Mad